Add heic image support

.github/ISSUE_TEMPLATE/feature_request.md

@@ -2,7 +2,7 @@
 name: Feature request
 about: Suggest an idea for this project
 title: ''
-labels: ''
+labels: 0. Needs triage, enhancement
 assignees: ''
 
 ---

.github/workflows/cypress.yml

@@ -9,6 +9,7 @@ on:
 
 env:
   APP_NAME: viewer
+  CYPRESS_baseUrl: http://127.0.0.1:8080/index.php
 
 jobs:
   cypress:
@@ -65,8 +66,13 @@ jobs:
         run: |
           mkdir data
           ./occ maintenance:install --verbose --database sqlite --admin-user admin --admin-pass admin 
-          ./occ app:enable ${{ env.APP_NAME }}
-          php -S localhost:8080 &
+          ./occ app:enable $APP_NAME
+          php -S 0.0.0.0:8080 &
+
+      - name: Wait for server
+        run: |
+            npm install -g wait-on
+            wait-on -i 500 -t 240000 $CYPRESS_baseUrl
 
       - name: Cypress run
         uses: cypress-io/github-action@v1
@@ -76,8 +82,5 @@ jobs:
           # cypress env
           working-directory: apps/${{ env.APP_NAME }}
           ci-build-id: ${{ github.sha }}-${{ github.run_number }}
-          # wait for server before running
-          wait-on: "http://localhost:8080"
         env:
           CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
-          CYPRESS_baseUrl: http://localhost:8080/index.php

.github/workflows/lint.yml

@@ -28,24 +28,70 @@ jobs:
       - name: Lint
         run: composer run lint
 
+  php-cs-fixer:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        php-versions: ['7.4']
+
+    name: cs php${{ matrix.php-versions }}
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v2
+
+    - name: Set up php
+      uses: shivammathur/setup-php@master
+      with:
+        php-version: ${{ matrix.php-versions }}
+        coverage: none
+
+    - name: Install dependencies
+      run: composer i
+
+    - name: Run coding standards check
+      run: composer run cs:check || ( echo 'Please run `composer run cs:fix` to format your code' && exit 1 )
+
   node:
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        node-versions: [12.x]
+        node-version: [12.x]
 
-    name: node${{ matrix.node-versions }}
+    name: eslint node${{ matrix.node-version }}
     steps:
       - uses: actions/checkout@v2
 
-      - name: Set up node ${{ matrix.node-versions }}
+      - name: Set up node ${{ matrix.node-version }}
         uses: actions/setup-node@v1
         with:
-          node-versions: ${{ matrix.node-versions }}
+          node-version: ${{ matrix.node-version }}
 
       - name: Install dependencies
         run: npm ci
 
       - name: Lint
         run: npm run lint
+
+  stylelint:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [12.x]
+
+    name: stylelint node${{ matrix.node-version }}
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up node ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Lint
+        run: npm run stylelint

.github/workflows/node.yml

@@ -13,16 +13,16 @@ jobs:
 
     strategy:
       matrix:
-        node-versions: [12.x]
+        node-version: [12.x]
 
-    name: node${{ matrix.node-versions }}
+    name: node${{ matrix.node-version }}
     steps:
       - uses: actions/checkout@v2
 
-      - name: Set up node ${{ matrix.node-versions }}
+      - name: Set up node ${{ matrix.node-version }}
         uses: actions/setup-node@v1
         with:
-          node-versions: ${{ matrix.node-versions }}
+          node-version: ${{ matrix.node-version }}
 
       - name: Install dependencies & build
         run: |

.gitignore

@@ -19,3 +19,5 @@ coverage/
 
 cypress/screenshots
 cypress/snapshots
+vendor
+.php_cs.cache

.php_cs.dist

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+require_once './vendor/autoload.php';
+
+use Nextcloud\CodingStandard\Config;
+
+$config = new Config();
+$config
+	->getFinder()
+	->notPath('build')
+	->notPath('l10n')
+	->notPath('src')
+	->notPath('vendor')
+	->in(__DIR__);
+return $config;

README.md

@@ -63,21 +63,24 @@ This will load all the necessary scripts and make the Viewer accessible trough j
 ### Open a file
 1. Open a file and let the viewer fetch the folder data
   ```js
-  OCA.Viewer.open('/path/to/file.jpg')
+  OCA.Viewer.open({path: '/path/to/file.jpg'})
   ```
 2. Open a file and profide a list of files
   ```js
-  OCA.Viewer.open('/path/to/file.jpg', [
-    	{
-			basename: 'file.jpg',
-			filename: '/path/to/file.jpg',
+  OCA.Viewer.open({
+		path: '/path/to/file.jpg',
+		list: [
+			{
+				basename: 'file.jpg',
+				filename: '/path/to/file.jpg',
+				...
+			},
 			...
-		},
-		...
-  ])
+		],
+  })
   ```
-  The second parametter requires an array of fileinfo. You can check how we generate a fileinfo object [here](https://github.com/nextcloud/viewer/blob/master/src/utils/fileUtils.js#L97) from a dav PROPFIND request data. There is currently no dedicated package for it, but this is coming. You can check the [photos](https://github.com/nextcloud/photos) repository where we also uses it.
-  
+  The list parameter requires an array of fileinfo. You can check how we generate a fileinfo object [here](https://github.com/nextcloud/viewer/blob/master/src/utils/fileUtils.js#L97) from a dav PROPFIND request data. There is currently no dedicated package for it, but this is coming. You can check the [photos](https://github.com/nextcloud/photos) repository where we also uses it.
+
 ### Close the viewer
 ```js
 OCA.Viewer.close()

appinfo/info.xml

@@ -5,15 +5,15 @@
     <name>Viewer</name>
     <summary>Simple file viewer with slideshow for media</summary>
     <description><![CDATA[Show your latest holiday photos and videos like in the movies, show a glimpse of your latest novel directly from your nextcloud, choose the best GIF of your collection thanks to the direct preview of your favorites files and many more!]]></description>
-    <version>1.3.0</version>
+    <version>1.4.0</version>
     <licence>agpl</licence>
     <author mail="[email protected]">John Molakvoæ</author>
     <namespace>Viewer</namespace>
     <category>tools</category>
     <bugs>https://github.com/nextcloud/viewer</bugs>
 	<screenshot>https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Viewer/viewer.png</screenshot>
     <dependencies>
-        <nextcloud min-version="19" max-version="19" />
+        <nextcloud min-version="20" max-version="20" />
     </dependencies>
     <default_enable />
 </info>

composer.json

@@ -1,12 +1,15 @@
 {
-  "name": "nextcloud/viewer",
-  "description": "Lint config for nextcloud/viewer",
-  "license": "MIT",
-  "config": {
-    "optimize-autoloader": true,
-    "classmap-authoritative": true
-  },
-  "scripts": {
-    "lint": "find . -name \\*.php -not -path './vendor/*' -exec php -l \"{}\" \\;"
-  }
+	"name": "nextcloud/viewer",
+	"config": {
+		"optimize-autoloader": true,
+		"classmap-authoritative": true
+	},
+	"scripts": {
+		"cs:fix": "php-cs-fixer fix",
+		"cs:check": "php-cs-fixer fix --dry-run --diff",
+		"lint": "find . -name \\*.php -not -path './vendor/*' -print0 | xargs -0 -n1 php -l"
+	},
+	"require-dev": {
+		"nextcloud/coding-standard": "^0.3.0"
+	}
 }