remove old link when editing #5690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current change works well when only changing a single link in a paragraph. Link in a paragraphFind more information on https://nextcloud.com as usual. -> should only change the link. Link with custom text-> should only change the href. |
max-nextcloud
force-pushed
the
fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link
branch
2 times, most recently
from
10bfdeb to
35f1d07
Compare
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
This was referenced Aug 29, 2024
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
max-nextcloud
requested changes
Feb 3, 2025
There was a problem hiding this comment.
As I said earlier... this will not work if the link is not the only thing in a paragraph.
@grnd-alt would you be up for picking this up again?
max-nextcloud
added
1. to develop
2. developing
and removed
1. to develop
3. to review
labels
grnd-alt
force-pushed
the
fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link
branch
from
f9e4df3 to
ab4b9d0
Compare
grnd-alt
force-pushed
the
fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link
branch
3 times, most recently
from
7b9f462 to
d8c8450
Compare
Signed-off-by: grnd-alt <[email protected]>
Signed-off-by: Max <[email protected]>
It is a proper e2e test driving the ui. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
This way we do not hand in the active state and avoid inconsistencies. Signed-off-by: Max <[email protected]>
grnd-alt
force-pushed
the
fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link
branch
2 times, most recently
from
1288fd9 to
026ae92
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5690 +/- ##
==========================================
+ Coverage 37.85% 38.03% +0.17%
==========================================
Files 750 735 -15
Lines 42637 42514 -123
Branches 1273 1262 -11
==========================================
+ Hits 16142 16171 +29
+ Misses 25873 25736 -137
+ Partials 622 607 -15 ☔ View full report in Codecov by Sentry. |
grnd-alt
force-pushed
the
fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link
branch
2 times, most recently
from
d52b7f4 to
e8281df
Compare
grnd-alt
force-pushed
the
fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link
branch
from
e8281df to
3db7595
Compare
Signed-off-by: grnd-alt <[email protected]>
grnd-alt
force-pushed
the
fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link
branch
from
3db7595 to
a333bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5516