Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] feat(screensharing): use setDisplayMediaRequestHandler #1022

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 9, 2025

☑️ Resolves

Old approach

  1. Using desktopCapturer get the list of available sources
  2. Promp to choose the source
  3. On Talk side in a special case in IS_DESKTOP instead of usign native getDisplayMedia get stream via getUserMedia for the selected chromeMediaSourceId like video stream

New approach

  1. On Talk side handle getDisplayMedia with a custom handler
  2. In the handler
    • Using desktopCapturer get the list of available sources
    • Promp to choose the source
  3. getDisplayMedia has the source, like in a web-browser

Differences

Pros:

  • No special handling on Talk side
  • Experimental support for native screen sharing source selector on macOS
    • Also allows to get audio stream

Cons:

  • No "Entire desktop with all screens" option for Windows and Linux-no-wayland
  • Issue #…

🖼️ Screenshots

image

🚧 Tasks

  • ...

@ShGKme ShGKme added enhancement New feature or request 2. developing labels Jan 9, 2025
@ShGKme ShGKme self-assigned this Jan 9, 2025
@ShGKme ShGKme force-pushed the feat/screen-sharing-via-displayMediaRequest-handler branch from 72c2647 to ce5e393 Compare January 29, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant