Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add logout button to welcome screen #1012

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • allows to re-auth in case Network Error persists and client stuck in the infinite loop

🖼️ Screenshots

🏚️ Before 🏡 After
2024-12-30_12h26_47 2024-12-30_12h26_12

🚧 Tasks

  • ...

- allows to re-auth in case Network Error persists

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added bug Something isn't working 3. to review labels Dec 30, 2024
@Antreesy Antreesy added this to the 🌠 Next Patch milestone Dec 30, 2024
@Antreesy Antreesy requested a review from ShGKme December 30, 2024 11:28
@Antreesy Antreesy self-assigned this Dec 30, 2024
@nickvergessen
Copy link
Member

in case Network Error persists and client stuck in the infinite loop

We should maybe add that info to the screen, instead of looping forever?

@Antreesy
Copy link
Contributor Author

We don't use translated strings or Vue components on welcome screen, so if we won't keep it 'always English' for simplicity, that would require more efforts

@nickvergessen
Copy link
Member

Well I mean:

  • No one plans to logout
  • The user is not aware that the request failed?
  • Should show a dedicated message for maintenance mode, talk being disabled, and other most common problems
  • Should show a generic error for others with an "error code" (http status code) so the user can be helped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants