Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chats): Don't mark conversation unread when receiving a reaction … #9180

Conversation

nickvergessen
Copy link
Member

…notification

☑️ Resolves

Steps

  1. User 1: Write a message in Talk room
  2. User 1: Open talk homepage
  3. User 2: React to the message from 1.
  4. User 1: Between the time the notifications refresh and the conversation list refreshes, see the chat as unread with counter "(1)" and subline being "User 2:" + your chat message

🏁 Checklist

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome for one-to-one chats and always-notify group chats, works properly

@nickvergessen
Copy link
Member Author

/backport to stable26

@nickvergessen nickvergessen merged commit 355935e into master Mar 28, 2023
@nickvergessen nickvergessen deleted the bugfix/9134/fix-notifications-about-reactions-marking-chat-unread branch March 28, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reaction to message shows as unread message of a conversation in left sidebar
2 participants