-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If cronErros is empty json_decode will return NULL #9920
Conversation
Fixes #9867 Signed-off-by: Roeland Jago Douma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ 💃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Signed-off-by: Morris Jobke <[email protected]>
I added some fixes for the tests. |
Codecov Report
@@ Coverage Diff @@
## master #9920 +/- ##
============================================
- Coverage 52.08% 34.99% -17.1%
- Complexity 25902 25904 +2
============================================
Files 1642 1642
Lines 95879 95884 +5
Branches 1318 1318
============================================
- Hits 49942 33550 -16392
- Misses 45937 62334 +16397
|
CI failure is a hiccup -> merging. |
Fixes #9867
Signed-off-by: Roeland Jago Douma [email protected]