Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable13] Add labels for Contacts menu and Settings #9433

Merged
merged 5 commits into from
May 10, 2018
Merged

[stable13] Add labels for Contacts menu and Settings #9433

merged 5 commits into from
May 10, 2018

Conversation

MorrisJobke
Copy link
Member

Backport of #9224

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 9, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 13.0.3 milestone May 9, 2018
@MorrisJobke MorrisJobke mentioned this pull request May 9, 2018
Merged
jancborchardt
jancborchardt approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only on mobile since laptop in repair, so not tested. But code changes look good.

@codecov
Copy link

codecov bot commented May 9, 2018 •
edited
Loading

Codecov Report

Merging #9433 into stable13 will decrease coverage by <.01%.
The diff coverage is 10.52%.

@@              Coverage Diff               @@
##             stable13    #9433      +/-   ##
==============================================
- Coverage       51.36%   51.36%   -0.01%     
  Complexity      25051    25051              
==============================================
  Files            1609     1609              
  Lines           95342    95348       +6     
  Branches         1376     1376              
==============================================
+ Hits            48973    48974       +1     
- Misses          46369    46374       +5
Impacted Files Coverage Δ Complexity Δ
core/templates/login.php 0% <ø> (ø) 0 <0> (ø) ⬇️
core/templates/layout.base.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/templates/layout.guest.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/templates/layout.user.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/js/js.js 66.37% <100%> (+0.07%) 0 <0> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)

@rullzer rullzer merged commit 3a013b1 into stable13 May 10, 2018
@rullzer rullzer deleted the backport/9224/accessibility-improvements-13 branch May 10, 2018 07:31
@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 13.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @rullzer @jancborchardt