Do not allow folder creation with quota of 0 #9372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
approved these changes
May 3, 2018
Mind to add those scenarios as test cases? |
|
@MorrisJobke sure I can. I just wanted to be sure we all agree this is the expected behavior before doing more work ;) |
Fixes #4577 Users with a quota of 0 are a special case. Since they can't (ever) create files on their own storage. Therefor it makes no real that they can create folders (and possible share those etc). Signed-off-by: Roeland Jago Douma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9372 +/- ##
===========================================
+ Coverage 51.2% 51.2% +<.01%
- Complexity 25581 25582 +1
===========================================
Files 1563 1563
Lines 88057 88058 +1
===========================================
+ Hits 45087 45089 +2
+ Misses 42970 42969 -1
|
|
Simple test case added |
icewind1991
approved these changes
May 4, 2018
|
This causes #11485 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4577
Users with a quota of 0 are a special case. Since they can't (ever)
create files on their own storage. Therefor it makes no real that they
can create folders (and possible share those etc).
Of course the alternative solution would be to do this in an app. However I feel this behavior makes the most sense...