Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused, deprecated icons #7236

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Remove unused, deprecated icons #7236

merged 1 commit into from
Nov 21, 2017

Conversation

pixelipo
Copy link
Contributor

As discussed in the SVG re-optimization tasks, several icons seem to be unused:

  • core/img/actions/pause-big.svg
  • core/img/actions/play-big.svg
  • core/img/actions/user-plus.svg
  • core/img/actions/user-times.svg

Does anyone know if these are used in an app? Last two don't even have a CSS class that calls them in core. @nextcloud/designers

Signed-off-by: Marin Treselj <[email protected]>
@pixelipo pixelipo added 3. to review Waiting for reviews technical debt labels Nov 21, 2017
@pixelipo pixelipo self-assigned this Nov 21, 2017
@pixelipo pixelipo mentioned this pull request Nov 21, 2017
14 tasks
@MorrisJobke
Copy link
Member

core/img/actions/play-big.svg

Not used in any app of the appstore.

core/img/actions/pause-big.svg

Not used in any app of the appstore.

core/img/actions/user-plus.svg
core/img/actions/user-times.svg

Those two are also not used in any app of the appstore.

@codecov
Copy link

codecov bot commented Nov 21, 2017

Codecov Report

Merging #7236 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7236      +/-   ##
============================================
- Coverage     50.84%   50.84%   -0.01%     
  Complexity    24548    24548              
============================================
  Files          1585     1585              
  Lines         93804    93804              
  Branches       1354     1354              
============================================
- Hits          47698    47697       -1     
- Misses        46106    46107       +1
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)

@skjnldsv skjnldsv merged commit 399a965 into master Nov 21, 2017
@skjnldsv skjnldsv deleted the remove-deprecated-icons branch November 21, 2017 13:52
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Nov 21, 2017
@jancborchardt
Copy link
Member

I mean, as far as I knew the play/pause big is used in the Gallery app for the details view / slideshow in the bottom right, but I'll check. (In any case we could use the normal icons and enlarge then.)

@pixelipo
Copy link
Contributor Author

@jancborchardt I think Gallery is using icon-view-play, which is still there (but I'm working on a PR for gallery to deprecate it as well)

@jancborchardt
Copy link
Member

@pixelipo ah of course, yes. The big play icon was only used in the old Music app then, so good on removing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants