-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable12] Fix anchor name for federated sharing settings #5914
Conversation
MorrisJobke
commented
Jul 28, 2017
- backport of Fix anchor name for federated sharing settings #5913
- fixes [stable12] Federated share icon is missing in Swedish translation #5911
Signed-off-by: Morris Jobke <[email protected]>
Thanks! |
@LukasReschke Merge or not merge? |
It solves the problem, so why not? |
@MorrisJobke Merge is okay but then I'm gonna build an RC5 :) |
Then 12.0.2 |
Yet, you released an 12.0.1RC5. |
So what? we dont need to include everything in the next release, otherwise its never going out because there is always stuff to review?! |
@nickvergessen No, just pointing out the fact that this was moved to 12.0.2 because Lukas wanted to release RC5 if this was merged. In other words, it could have been merged, but now we have to wait another month or so. But hey, better to wait. :) |
No. Monday is still the planned date, because the reason for the RC5 was to give some minor minor minor stuff a chance to be tested. 😉 With this here we would need to have wait. We just want to get back to a more serious release testing and not just merge stuff in very late without an RC. 😉 |
@MorrisJobke Makes sense. @nickvergessen Not my intention to seem offensive. |