Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix anchor name for federated sharing settings #5914

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

@enoch85
Copy link
Member

enoch85 commented Jul 29, 2017

Thanks!

@MorrisJobke
Copy link
Member Author

@LukasReschke Merge or not merge?

@enoch85
Copy link
Member

enoch85 commented Jul 31, 2017

Merge or not merge?

It solves the problem, so why not?

@LukasReschke
Copy link
Member

@MorrisJobke Merge is okay but then I'm gonna build an RC5 :)

@MorrisJobke
Copy link
Member Author

Then 12.0.2

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 2, 2017
@enoch85
Copy link
Member

enoch85 commented Aug 4, 2017

Yet, you released an 12.0.1RC5.

@nickvergessen
Copy link
Member

So what? we dont need to include everything in the next release, otherwise its never going out because there is always stuff to review?!

@enoch85
Copy link
Member

enoch85 commented Aug 4, 2017

@MorrisJobke Merge is okay but then I'm gonna build an RC5 :)

Then 12.0.2

@nickvergessen No, just pointing out the fact that this was moved to 12.0.2 because Lukas wanted to release RC5 if this was merged.

In other words, it could have been merged, but now we have to wait another month or so.

But hey, better to wait. :)

@MorrisJobke
Copy link
Member Author

In other words, it could have been merged, but now we have to wait another month or so.

No. Monday is still the planned date, because the reason for the RC5 was to give some minor minor minor stuff a chance to be tested. 😉

With this here we would need to have wait. We just want to get back to a more serious release testing and not just merge stuff in very late without an RC. 😉

@enoch85
Copy link
Member

enoch85 commented Aug 4, 2017

@MorrisJobke Makes sense.

@nickvergessen Not my intention to seem offensive.

@MorrisJobke MorrisJobke merged commit 2abc499 into stable12 Aug 8, 2017
@MorrisJobke MorrisJobke deleted the 12-5913 branch August 8, 2017 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants