Fix renaming of non-renamble mounts #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $manager->moveMount($sourceMountPoint, $mount1->getMountPoint()); | ||
| if ($internalPath1 === '') { | ||
| if ($mount1 instanceof MoveableMount) { | ||
| if ($this->isTargetAllowed($absolutePath2)) { |
There was a problem hiding this comment.
merge with the mount1 instanceof MoveableMount if above?
There was a problem hiding this comment.
That would require a seperate ($internalPath1 === '' && !$mount1 instanceof MoveableMount) case, imo this one is clearer than splitting it up
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
mount-rename
branch
from
e7050ab to
359a583
Compare
Codecov Report
@@ Coverage Diff @@
## master #5596 +/- ##
=========================================
Coverage ? 53.98%
Complexity ? 22466
=========================================
Files ? 1390
Lines ? 85980
Branches ? 1328
=========================================
Hits ? 46418
Misses ? 39562
Partials ? 0
|
|
May this go into a bugfix release of 12.x or do we need to wait until 13.x? |
It is already backported to stable12 and will land in 12.0.1: #5757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nextcloud/groupfolders#33