Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webhook_listener): Remove trailing comma #50775

Closed
wants to merge 1 commit into from
Closed

fix(webhook_listener): Remove trailing comma #50775

wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

Summary

Also added query type IQueryBuilder::PARAM_STR

Checklist

@solracsf solracsf added bug 3. to review Waiting for reviews labels Feb 12, 2025
@solracsf solracsf added this to the Nextcloud 32 milestone Feb 12, 2025
@solracsf
Copy link
Member Author

/backport to stable31

@solracsf
Copy link
Member Author

/backport to stable30

@solracsf solracsf requested review from come-nc and Altahrim February 12, 2025 11:03
@solracsf solracsf enabled auto-merge February 12, 2025 13:25
provokateurin
provokateurin requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no sense, there is no syntax error.
Since PHP 8.0 trailing commas are allowed.
And multiple of our static code analysis tools would have caught such an error.

@solracsf solracsf disabled auto-merge February 13, 2025 08:59
@solracsf solracsf closed this Feb 13, 2025
@solracsf solracsf deleted the removeTrailingComma branch February 13, 2025 08:59
@solracsf solracsf mentioned this pull request Feb 13, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin requested changes

@come-nc come-nc Awaiting requested review from come-nc

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request bug
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

[Bug]: syntax eror generate a lot of troubles enabling app_api
2 participants
@solracsf @provokateurin