Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(files_reminders): Reduce db queries on propfind #50244

Merged
merged 6 commits into from
Feb 21, 2025
Merged

perf(files_reminders): Reduce db queries on propfind #50244

merged 6 commits into from
Feb 21, 2025
+137 −48

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 17, 2025

Summary

  • Add caching for reminders
  • Reduces database queries by n number of nodes in the directory per PROPFIND

Checklist

@Pytal Pytal added this to the Nextcloud 31 milestone Jan 17, 2025
@Pytal Pytal requested a review from icewind1991 January 17, 2025 23:07
@Pytal Pytal self-assigned this Jan 17, 2025
@icewind1991

This comment was marked as resolved.

Sign in to view
@Pytal

This comment was marked as resolved.

Sign in to view
@icewind1991

This comment was marked as resolved.

Sign in to view
@Pytal Pytal force-pushed the perf/cache-file-reminders branch from f04cc38 to 17d93de Compare January 24, 2025 22:27
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@Pytal Pytal force-pushed the perf/cache-file-reminders branch from 17d93de to 7f72601 Compare January 31, 2025 22:52
@Pytal Pytal force-pushed the perf/cache-file-reminders branch from 7f72601 to 33ef228 Compare February 13, 2025 17:25
@Pytal Pytal marked this pull request as ready for review February 13, 2025 17:25
@Pytal Pytal requested review from icewind1991, a team, provokateurin and come-nc and removed request for a team February 13, 2025 17:25
@AndyScherzinger AndyScherzinger force-pushed the perf/cache-file-reminders branch from 33ef228 to e2edf02 Compare February 19, 2025 20:13
@Pytal Pytal force-pushed the perf/cache-file-reminders branch from e2edf02 to 48744e1 Compare February 20, 2025 22:13
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 20, 2025
@Pytal Pytal enabled auto-merge February 20, 2025 22:16
@Pytal Pytal disabled auto-merge February 20, 2025 22:21
@Pytal
Copy link
Member Author

Pytal commented Feb 20, 2025

CI failure unrelated

Failure comes from #50910, cc @skjnldsv

@Pytal Pytal force-pushed the perf/cache-file-reminders branch from d3d4445 to d249b60 Compare February 21, 2025 22:03
@Pytal Pytal enabled auto-merge February 21, 2025 22:26
@Pytal Pytal merged commit ceb6f56 into master Feb 21, 2025
190 checks passed
@Pytal Pytal deleted the perf/cache-file-reminders branch February 21, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc Awaiting requested review from come-nc come-nc was automatically assigned from nextcloud/server-backend

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files performance 🚀
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @icewind1991 @provokateurin @blizzz