-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(systemtags): add setting to block non admin to create system tags #49514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d561ba1
to
7ed6833
Compare
7ed6833
to
c158e06
Compare
8c7bd05
to
06bb2f1
Compare
e27715d
to
d8d3c7e
Compare
5b049ce
to
5cf90d5
Compare
5cf90d5
to
f7e6dc9
Compare
sorbaugh
approved these changes
Jan 13, 2025
provokateurin
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor things, LGTM
f7e6dc9
to
001ec5a
Compare
/compile |
skjnldsv
approved these changes
Jan 16, 2025
Merged
69f8d5e
to
76ad5e2
Compare
76ad5e2
to
2df437f
Compare
/compile |
2fcd63f
to
4840a06
Compare
4840a06
to
dc9f724
Compare
b7a29e3
to
ff81fb9
Compare
Merged
ff81fb9
to
a0b0ea3
Compare
/compile |
artonge
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking on the naming. But not blocking :)
cd5a4a8
to
7c4295c
Compare
/compile |
artonge
approved these changes
Jan 21, 2025
55cb8bb
to
b18f4d7
Compare
/compile |
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Signed-off-by: nfebe <[email protected]>
Added support for the `only_admin_can_create` flag in system tags. The UI now hides the option to create tags when this flag is enabled, ensuring compliance with admin settings. Signed-off-by: nfebe <[email protected]>
543c295
to
abf840b
Compare
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows admins to restrict tag creation to admins only
Switch with:
TODO
Checklist