fix(setupCheck): Only warn when memcache present w/o memcached #45242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://help.nextcloud.com/t/update-to-28-0-5-memcached-error-now/190125
Summary
Prior to #42812 the check for the common mistake of installing PHP modules
memcache
rather thanmemcached
only warned ifmemcached
was missing whilememcache
was installed. When the setup checks were moved to the new API, the logic was changed (probably accidentally) so that it warned anytimememcache
was present. This means existing environments started getting a warning about a problem that really isn't a problem.Restores the old logic. Also removes the old ancient third-party doc link that isn't relevant and only creates confusion. Also tries to make the next step super obvious when this warning is triggered legitimately.
TODO
Checklist