Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add bidirectional text support #42471

Closed
wants to merge 12 commits into from
Closed

WIP - Add bidirectional text support #42471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e94743f
Set layout direction based on locale
ghorbani-ali Dec 15, 2023
11056eb
Add unittest for language direction
ahangarha Dec 17, 2023
04f55d1
Improve naming methods, variables and const
ghorbani-ali Dec 19, 2023
bdc6799
Add bidi support in core directory
ahangarha Dec 19, 2023
fee1aeb
Add bidi support in apps directory
ahangarha Dec 20, 2023
e18f429
Update unittest based on the new method name
ghorbani-ali Dec 20, 2023
d7ba707
Fix bakcground position based on direction
ahangarha Dec 23, 2023
e9feb43
Fix shorthand paddings and margins
ahangarha Dec 23, 2023
7875d2f
Fix float and clear
ahangarha Dec 23, 2023
2817ad2
Fix other background-positions
ahangarha Dec 23, 2023
82142aa
Minor fix in link button icon position
ahangarha Dec 24, 2023
e22f565
Update header left and right to start and end
ahangarha Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/comments/src/components/Comment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ $comment-padding: 10px;
}

&__actions {
margin-left: $comment-padding !important;
margin-inline-start: $comment-padding !important;
}

&__author {
Expand All @@ -320,8 +320,8 @@ $comment-padding: 10px;

&_loading,
&__timestamp {
margin-left: auto;
text-align: right;
margin-inline-start: auto;
text-align: end;
white-space: nowrap;
color: var(--color-text-maxcontrast);
}
Expand All @@ -338,7 +338,7 @@ $comment-padding: 10px;
&__submit {
position: absolute !important;
bottom: 0;
right: 0;
inset-inline-end: 0;
}

&__message {
Expand Down
8 changes: 4 additions & 4 deletions apps/dashboard/src/DashboardApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ export default {
background-size: 32px;
width: 32px;
height: 32px;
margin-right: 16px;
margin-inline-end: 16px;
background-position: center;
float: left;
margin-top: -6px;
Expand Down Expand Up @@ -583,7 +583,7 @@ export default {
margin:auto;
background-position: 16px center;
padding: 12px 16px;
padding-left: 36px;
padding-inline-start: 36px;
border-radius: var(--border-radius-pill);
max-width: 200px;
opacity: 1;
Expand Down Expand Up @@ -635,7 +635,7 @@ export default {
background-color: var(--color-background-hover);
border: 2px solid var(--color-main-background);
border-radius: var(--border-radius-large);
text-align: left;
text-align: start;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
Expand All @@ -660,7 +660,7 @@ export default {

input[type='checkbox'].checkbox + label:before {
position: absolute;
right: 12px;
inset-inline-end: 12px;
top: 16px;
}

Expand Down
10 changes: 5 additions & 5 deletions apps/dav/css/schedule-response.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ form #selectPartStatForm label {
}

form #selectPartStatForm label:first-of-type {
border-top-left-radius: 4px;
border-bottom-left-radius: 4px;
border-start-start-radius: 4px;
border-end-start-radius: 4px;
}

form #selectPartStatForm label:last-of-type {
border-top-right-radius: 4px;
border-bottom-right-radius: 4px;
border-start-end-radius: 4px;
border-end-end-radius: 4px;
}

form #selectPartStatForm label span {
Expand Down Expand Up @@ -75,4 +75,4 @@ form input[type="submit"] {
display: block;
margin: 0 auto;
padding: 11px 20px 9px
}
}
9 changes: 5 additions & 4 deletions apps/dav/src/components/AvailabilityForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,13 @@ export default {
width: 120px;
}
.time-zone {
padding: 32px 12px 12px 0;
display: flex;
flex-wrap: wrap;
padding-block: 32px 12px;
padding-inline: 0 12px;
display: flex;
flex-wrap: wrap;

&__heading {
margin-right: calc(var(--default-grid-baseline) * 2);
margin-inline-end: calc(var(--default-grid-baseline) * 2);
line-height: var(--default-clickable-area);
font-weight: bold;
}
Expand Down
4 changes: 2 additions & 2 deletions apps/federatedfilesharing/src/components/PersonalSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export default {
margin-top: 0.5rem;
button {
display: inline-flex;
margin-left: 0.5rem;
margin-inline-start: 0.5rem;
margin-top: 1rem;
}
&__website-button {
Expand All @@ -198,6 +198,6 @@ export default {
white-space: pre-wrap;
}
#cloudid {
margin-left: 0.25rem;
margin-inline-start: 0.25rem;
}
</style>
6 changes: 3 additions & 3 deletions apps/federation/css/settings-admin.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,22 @@
.removeTrustedServer {
display: none;
vertical-align:middle;
padding-left: 10px;
padding-inline-start: 10px;
}

#ocFederationAddServerButton {
cursor: pointer;
}

#listOfTrustedServers .status {
margin-right: 10px;
margin-inline-end: 10px;
}

#listOfTrustedServers .icon {
cursor: pointer;
display: inline-block;
vertical-align: middle;
margin-left: 10px;
margin-inline-start: 10px;
}

#ocFederationAddServer #serverUrl {
Expand Down
2 changes: 1 addition & 1 deletion apps/files/css/detailsView.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/files/css/detailsView.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions apps/files/css/detailsView.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
}

.app-sidebar .thumbnailContainer.large {
margin-left: -15px;
margin-right: -35px; /* 15 + 20 for the close button */
margin-inline-start: -15px;
margin-inline-end: -35px; /* 15 + 20 for the close button */
margin-top: -15px;
}

Expand Down Expand Up @@ -68,15 +68,15 @@
overflow-x: hidden;
padding-top: 14px;
font-size: 80%;
margin-left: 0;
margin-inline-start: 0;
}

.app-sidebar .thumbnail {
width: 100%;
min-height: 75px;
display: inline-block;
float: left;
margin-right: 10px;
margin-inline-end: 10px;
background-size: contain;
background-repeat: no-repeat;
}
Expand Down Expand Up @@ -121,7 +121,7 @@
.app-sidebar .close {
position: absolute;
top: 0;
right: 0;
inset-inline-end: 0;
opacity: .5;
z-index: 1;
width: 44px;
Expand Down
2 changes: 1 addition & 1 deletion apps/files/css/files.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/files/css/files.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading