Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate code integrity to SetupCheck API #41312

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Migrate code integrity to SetupCheck API #41312

merged 7 commits into from
Jan 16, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 6, 2023 •
edited
Loading

Summary

Migrate code integrity check to new setup check API, but we need to figure out how to avoid a regression here

TODO

  • Add details to description
  • Find a way to provide a link to rescan (maybe simply wait for cached setup checks and rework this into a cached one)

Checklist

@come-nc come-nc added the 2. developing Work in progress label Nov 6, 2023
@come-nc come-nc added this to the Nextcloud 29 milestone Nov 6, 2023
@come-nc come-nc self-assigned this Nov 6, 2023
This was referenced Nov 6, 2023
Merged
Closed
@come-nc come-nc force-pushed the feat/migrate-code-integrity-check branch from 251eeed to 276362a Compare January 9, 2024 16:53
@come-nc come-nc force-pushed the feat/migrate-code-integrity-check branch from 905adaa to 69cd094 Compare January 11, 2024 11:19
@come-nc come-nc changed the base branch from master to enh/add-rich-object-support-to-setupchecks January 11, 2024 11:20
@come-nc come-nc force-pushed the enh/add-rich-object-support-to-setupchecks branch from dae9fa2 to e884ffd Compare January 11, 2024 13:03
Base automatically changed from enh/add-rich-object-support-to-setupchecks to master January 11, 2024 16:15
@come-nc come-nc force-pushed the feat/migrate-code-integrity-check branch from 540c82c to c998680 Compare January 15, 2024 10:50
@come-nc come-nc marked this pull request as ready for review January 15, 2024 13:08
@come-nc come-nc added 21-feedback 3. to review Waiting for reviews and removed 2. developing Work in progress 21-feedback labels Jan 15, 2024
@come-nc come-nc requested review from nickvergessen, susnux, a team, ArtificialOwl and blizzz and removed request for a team January 15, 2024 13:10
@come-nc come-nc requested a review from sorbaugh January 15, 2024 13:10
@nickvergessen nickvergessen removed their request for review January 15, 2024 15:32
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 15, 2024
@come-nc come-nc merged commit 80d58f0 into master Jan 16, 2024
51 of 52 checks passed
@come-nc come-nc deleted the feat/migrate-code-integrity-check branch January 16, 2024 08:04
@come-nc come-nc mentioned this pull request Jan 18, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@Altahrim Altahrim Altahrim approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
5 participants
@come-nc @ArtificialOwl @Altahrim @artonge @blizzz