-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More comprehensive wording on devices' wipe action button #38882
More comprehensive wording on devices' wipe action button #38882
Conversation
Signed-off-by: Jérôme Herbinet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jérôme Herbinet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to improve the wording! :) I am worried that "Disconnect all devices and delete local data" is quite long. How about "Delete data from all devices"? It provides more info than "Wipe all devices" (and probably translates better as well) and there is a confirmation modal to explain further anyway. What do you think? @nextcloud/designers
@nimishavijay thanks for your comment :-)
|
Absolutely agreed about the modal! How about the item in the action menu is short and the modal has more info, like this: Action menu item:
Modal:
Things to note:
What do you think? Does this sufficiently communicate the result of the action? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another common way to say this for example in operating systems and hard disk manipulation software they often use "Erase device(s)" (Most times with a text that gives more details and of course a design that shows how dangerous the action is)
See respawn #40161 |
Replace "Wipe all devices" with "Disconnect all devices and delete local data".
IMO, of course, it's longer, but the "Wipe all devices" wording lacks clarity on the action incurred.
So this new wording might be a better compromise.
Checklist