Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix too dark or bright primary element color #38159

Merged
merged 3 commits into from
May 11, 2023
Merged

fix too dark or bright primary element color #38159

merged 3 commits into from
May 11, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 9, 2023 •
edited
Loading

To reproduce: choose a very dark primary color and select the dark mode.

Before After
image image

@szaimen szaimen added the 2. developing Work in progress label May 9, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 9, 2023
@szaimen szaimen force-pushed the enh/noid/fix-themed-icons branch 2 times, most recently from b9ef482 to aa0c5ea Compare May 9, 2023 20:15
@szaimen szaimen added bug design Design, UI, UX, etc. 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 9, 2023
@szaimen szaimen modified the milestones: Nextcloud 28, Nextcloud 27 May 9, 2023
@szaimen szaimen marked this pull request as ready for review May 9, 2023 20:26
@szaimen szaimen requested review from jancborchardt, nimishavijay, a team, susnux, nfebe and Pytal and removed request for a team May 9, 2023 20:28
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 9, 2023
@szaimen szaimen marked this pull request as draft May 9, 2023 20:33
@szaimen szaimen force-pushed the enh/noid/fix-themed-icons branch 2 times, most recently from 9eccd3a to f9a246e Compare May 9, 2023 20:45
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 9, 2023
@szaimen szaimen marked this pull request as ready for review May 9, 2023 20:45
@szaimen szaimen changed the title try to fix too dark or bright themed icons fix too dark or bright themed icons May 9, 2023
@skjnldsv skjnldsv mentioned this pull request May 10, 2023
Merged
nimishavijay
nimishavijay reviewed May 10, 2023
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the screenshot 👍 as long as it is not affected in light mode it is good to go

@szaimen
Copy link
Contributor Author

szaimen commented May 10, 2023

Can someone please restart drone for me? Thanks a lot!

@nickvergessen nickvergessen force-pushed the enh/noid/fix-themed-icons branch from f9a246e to b70b1f6 Compare May 10, 2023 13:41
@szaimen szaimen mentioned this pull request May 10, 2023
Merged
@szaimen szaimen changed the title fix too dark or bright themed icons fix too dark primary element color May 10, 2023
@szaimen szaimen force-pushed the enh/noid/fix-themed-icons branch from 0f70d24 to eb87705 Compare May 10, 2023 14:38
@szaimen szaimen force-pushed the enh/noid/fix-themed-icons branch from ca11186 to ccdaad1 Compare May 11, 2023 12:12
@szaimen
adjust tests
4a89b7e 
Signed-off-by: Simon L <[email protected]>
@szaimen szaimen force-pushed the enh/noid/fix-themed-icons branch from ccdaad1 to 4a89b7e Compare May 11, 2023 12:15
@szaimen szaimen changed the title fix too dark primary element color fix too dark or bright primary element color May 11, 2023
susnux
susnux approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, very nice!

@szaimen szaimen enabled auto-merge May 11, 2023 13:02
@szaimen szaimen disabled auto-merge May 11, 2023 13:51
@szaimen szaimen closed this May 11, 2023
@szaimen szaimen reopened this May 11, 2023
jancborchardt
jancborchardt approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@szaimen
Copy link
Contributor Author

szaimen commented May 11, 2023

CI failure unrelated

@szaimen szaimen merged commit 83dcb20 into master May 11, 2023
@szaimen szaimen deleted the enh/noid/fix-themed-icons branch May 11, 2023 21:58
@szaimen
Copy link
Contributor Author

szaimen commented May 12, 2023

I wonder should we backport this or rather not?

@szaimen szaimen mentioned this pull request May 12, 2023
Closed
This was referenced Jun 9, 2023
Open
Closed
@grrdvnk grrdvnk mentioned this pull request Jul 24, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@susnux susnux susnux approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@szaimen @nickvergessen @jancborchardt @susnux @nimishavijay