Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add setup check warning if instance is in debug mode #38133

Merged
merged 1 commit into from
May 9, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 9, 2023

I've seen a couple of instances running in debug mode in production recently and thought it might be a good idea to add a setup check for this since we only recommend it for development purposes as it may widen security measurements and also could introduce unexpected behaviour for regular users where the js assets are not automatically invalidated in the browser cache.

Checklist

@juliusknorr juliusknorr requested review from szaimen, a team, susnux and nfebe and removed request for a team May 9, 2023 05:36
@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews labels May 9, 2023
@juliusknorr juliusknorr added this to the Nextcloud 27 milestone May 9, 2023
@solracsf
Copy link
Member

solracsf commented May 9, 2023

as it may widen security measurements and also could introduce unexpected behaviour for regular users.

Maybe add it to the warning too?

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@skjnldsv skjnldsv mentioned this pull request May 9, 2023
@skjnldsv skjnldsv mentioned this pull request May 9, 2023
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv merged commit ca88a18 into master May 9, 2023
@skjnldsv skjnldsv deleted the feat/setupcheck-debug branch May 9, 2023 08:14
@szaimen szaimen modified the milestones: Nextcloud 28, Nextcloud 27 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants