Fix error on delete in ChunkingV2Plugin #38100
Conversation
Signed-off-by: Lorenzo Tanganelli <[email protected]>
tanganellilore
force-pushed
the
fix_delete_ChunkingV2Plugin
branch
from
34cdbed to
d920e65
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return true; | ||
| } | ||
|
|
||
| [$storage, $storagePath] = $this->getUploadStorage($this->uploadPath); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
There was a problem hiding this comment.
The test if (!$this->uploadFolder instanceof UploadFolder) { from before is missing, leading to this psalm warning. Please add it back.
I cannot judge the rest I do not understand the change.
There was a problem hiding this comment.
that's evaluated in checkPrerequisites()
There was a problem hiding this comment.
Yes correct, is evaluated in checkPrerequisites() function, as the same of other functions
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable26 |
Summary
This PR fix the error on "delete" call when is used and storage class that is not IChunkedFileWrite::class.
Implementation is the same of other "before" method
TODO
Checklist