add command for getting fileinfo for debugging #37525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
come-nc
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
come-nc
reviewed
Apr 3, 2023
|
icewind1991
force-pushed
the
file-debug-info
branch
from
2743ec1 to
c7410ff
Compare
| $bucket = array_pop($parts); | ||
| $output->writeln(" bucket: " . $bucket); | ||
| if ($node instanceof \OC\Files\Node\File) { | ||
| $output->writeln(" object id: " . $storage->getURN($node->getId())); |
Check notice
Code scanning / Psalm
PossiblyNullOperand
icewind1991
force-pushed
the
file-debug-info
branch
2 times, most recently
from
7858d4b to
bbb2474
Compare
icewind1991
force-pushed
the
file-debug-info
branch
2 times, most recently
from
1b6381a to
96f9c17
Compare
icewind1991
force-pushed
the
file-debug-info
branch
from
96f9c17 to
c99f3ae
Compare
icewind1991
force-pushed
the
file-debug-info
branch
from
c99f3ae to
579d37a
Compare
Pytal
reviewed
Apr 14, 2023
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
file-debug-info
branch
from
579d37a to
c5dfa1c
Compare
Pytal
reviewed
Apr 18, 2023
There was a problem hiding this comment.
In-place of the manual stdout formatting we could use the built-in Symfony methods https://symfony.com/doc/current/console/style.html#helper-methods ?
come-nc
approved these changes
Apr 20, 2023
blizzz
approved these changes
Apr 20, 2023
|
/backport to stable26 |
|
/backport to stable25 |
This was referenced May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to provide information that might be useful when debugging issues as well as perform some sanity checks.
This hopefully allows people without knowledge of the Nextcloud internals to access debug information that is currently only accessible trough manual database querying or other convoluted steps.
Currently includes:
(Possible) future work