Fix cypress tests for files_versions #37345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
changed the title
artonge
changed the title
skjnldsv
approved these changes
Mar 22, 2023
|
Ok, but with one comment :) |
skjnldsv
requested changes
Mar 22, 2023
artonge
force-pushed
the
artonge/fix_files_version_cypress_tests
branch
4 times, most recently
from
a7b24de to
f6084c9
Compare
skjnldsv
added
2. developing
artonge
force-pushed
the
artonge/fix_files_version_cypress_tests
branch
from
4207857 to
13f76e0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
In files_versions cypress tests, we wait for 1000ms between each versions uploads to make sure that the server properly create a version. Under 1s the serve does not create a version. This commit increases the wait time as it might help to ensure that the time span is enough between two uploads. Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix_files_version_cypress_tests
branch
from
8de755f to
ae0ec6f
Compare
|
Strongly suspecting auto expiration from deleting files, let's see |
artonge
force-pushed
the
artonge/fix_files_version_cypress_tests
branch
from
128955a to
f0a1163
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix_files_version_cypress_tests
branch
from
f0a1163 to
5dc64eb
Compare
artonge
commented
Apr 3, 2023
There was a problem hiding this comment.
@skjnldsv I managed to get the tests working again. I was tricked by the auto expiration process...
The culprit is that I move the occ config:system:set versions_retention_obligation call from dockerNode.ts to version_expiration.cy.ts.
Note that:
- I extended the cypress workflow to extract logs and data directory. Can be remove but seems useful. Ok to keep?
- The change also contains logic to use a random file name instead of 'test.txt'. Not needed, but it's here and it works.
Comment on lines
+74
to
+76
| if (!process.env.CI) { | ||
| stopNextcloud() | ||
| } |
There was a problem hiding this comment.
Needed to extract logs and data directory
artonge
changed the title
come-nc
reviewed
Apr 4, 2023
Signed-off-by: Louis Chemineau <[email protected]>
come-nc
approved these changes
Apr 4, 2023
delete-merged-branch
bot
deleted the
artonge/fix_files_version_cypress_tests
branch
|
/backport to stable26 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In files_versions cypress tests, we wait for 1000ms between each versions uploads to make sure that the server properly create a version. Under 1s the serve does not create a version.This commit increases the wait time as it might help to ensure that the time span is enough between two uploads.The automatic versions expiration process was kicking in during the tests, making some versions unavailable. I changed the tests to isolate expiration process testing from other tests.