Also limit the password length on reset #35965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ArtificialOwl,
icewind1991,
blizzz,
come-nc and
PVince81
and removed request for
a team
|
/backport to stable25 |
come-nc
approved these changes
Jan 3, 2023
| @@ -240,6 +240,10 @@ public function setPassword(string $token, string $userId, string $password, boo | |||
| $this->eventDispatcher->dispatchTyped(new BeforePasswordResetEvent($user, $password)); | |||
| \OC_Hook::emit('\OC\Core\LostPassword\Controller\LostController', 'pre_passwordReset', ['uid' => $userId, 'password' => $password]); | |||
|
|
|||
| if (strlen($password) > 469) { | |||
There was a problem hiding this comment.
Magic number? We have no constant/config for this?
There was a problem hiding this comment.
Magic number for now due to upcoming release and necessary backport.
But yeah it yields for a const.
Scheduled myself a todo for next week
There was a problem hiding this comment.
Looks good to me.
Is the issue fixed or can I collabrate to fix this issue?
PVince81
added
4. to release
nickvergessen
deleted the
bugfix/noid/limit-length-when-reseting-password
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #33110
Checklist