Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow app type session which we load in base.php #34145

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

nickvergessen
Copy link
Member

Ref

OC_App::loadApps(['session']);

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Sep 19, 2022
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Sep 19, 2022
@nickvergessen nickvergessen requested review from a team, PVince81, ArtificialOwl, CarlSchwan and blizzz and removed request for a team September 19, 2022 18:46
@blizzz blizzz mentioned this pull request Sep 20, 2022
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen
Copy link
Member Author

nickvergessen commented Sep 21, 2022

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristophWurst
Copy link
Member

With https://docs.nextcloud.com/server/stable/developer_manual/app_development/bootstrap.html#bootstrapping-process app types should be more or less obsolete, right? The historic issue was that the loading order need to be adjusted so that some apps run earlier then others. With the two step process we first register, then we act. So the order doesn't matter.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@nickvergessen
Copy link
Member Author

With https://docs.nextcloud.com/server/stable/developer_manual/app_development/bootstrap.html#bootstrapping-process app types should be more or less obsolete, right? The historic issue was that the loading order need to be adjusted so that some apps run earlier then others. With the two step process we first register, then we act. So the order doesn't matter.

While you got a point there, I don't dare to touch this yet

@nickvergessen nickvergessen merged commit 18431c2 into master Sep 21, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/allow-app-type-session branch September 21, 2022 13:48
@blizzz blizzz mentioned this pull request Sep 22, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants