-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow app type session which we load in base.php #34145
Conversation
Signed-off-by: Joas Schilling <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, once this was merged, raised at nextcloud/appstore#926 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
With https://docs.nextcloud.com/server/stable/developer_manual/app_development/bootstrap.html#bootstrapping-process app types should be more or less obsolete, right? The historic issue was that the loading order need to be adjusted so that some apps run earlier then others. With the two step process we first register, then we act. So the order doesn't matter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐘
While you got a point there, I don't dare to touch this yet |
Ref
server/lib/base.php
Line 674 in 80f6a58