Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy #dir element in files list #33373

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Remove legacy #dir element in files list #33373

merged 1 commit into from
Jul 27, 2022

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Jul 27, 2022 •
edited
Loading

Removed legacy "#dir" input element in the DOM.

Apps should use OCA.Files.App.currentFileList or
OCA.Sharing.PublicApp.fileList and call getCurrentDirectory() to
retrieve the current directory and changeDirectory() to change it.

Reasons

  • accessibility tools are unhappy about duplicate ids in the code.
  • this is a really really old (OC <= 5) and dirty way for managing state

Affected apps from the release bundle

Todos

Tests

  • TEST: manually tested file list page refresh with root dir
  • TEST: manually tested file list page refresh with non-default dir
  • TEST: manually tested public link page refresh with root dir
  • TEST: manually tested public link page refresh with non-default dir

@PVince81
Remove legacy #dir element in files list
8be9b04 
Removed legacy "#dir" input element in the DOM.

Apps should use OCA.Files.App.currentFileList or
OCA.Sharing.PublicApp.fileList and call getCurrentDirectory() to
retrieve the current directory and changeDirectory() to change it.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 added this to the Nextcloud 25 milestone Jul 27, 2022
@PVince81 PVince81 self-assigned this Jul 27, 2022
@PVince81 PVince81 mentioned this pull request Jul 27, 2022
Merged
@PVince81 PVince81 merged commit fc276ba into master Jul 27, 2022
@PVince81 PVince81 deleted the techdebt/noid/remove-legacy-dir branch July 27, 2022 11:44
@PVince81 PVince81 mentioned this pull request Jul 27, 2022
Closed
This was referenced Jul 27, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
@otetard otetard mentioned this pull request Nov 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@PVince81 PVince81

Labels
3. to review Waiting for reviews accessibility technical debt
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @juliusknorr @JuliaKirschenheuter @CarlSchwan