Add a single public api for resolving a cloud id to a user and remote and back #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @schiessle to be potential reviewers. |
icewind1991
force-pushed
the
cloud-id-resolve
branch
from
1547393 to
3117228
Compare
icewind1991
force-pushed
the
cloud-id-resolve
branch
from
3117228 to
acba0cb
Compare
|
All green, @schiessle @MorrisJobke @rullzer please review |
MorrisJobke
requested changes
Feb 7, 2017
icewind1991
force-pushed
the
cloud-id-resolve
branch
from
a7b3f80 to
dfaf999
Compare
… and back Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
cloud-id-resolve
branch
from
dfaf999 to
ae66cf8
Compare
|
Rebased and added tests |
MorrisJobke
approved these changes
Feb 9, 2017
nickvergessen
requested changes
Feb 9, 2017
| $message = 'Not allowed to create a federated share with the same user.'; | ||
| $message_t = $this->l->t('Not allowed to create a federated share with the same user'); | ||
| $this->logger->debug($message, ['app' => 'Federated File Sharing']); | ||
| throw new \Exception($message_t); | ||
| } | ||
|
|
||
| $share->setSharedWith($user . '@' . $remote); | ||
|
|
||
| $share->setSharedWith(rtrim($cloudId->getId(), '/')); |
There was a problem hiding this comment.
that should be done by getId()
| public function getRemote() { | ||
| return $this->remote; | ||
| } | ||
| } |
| <?php | ||
| /** | ||
| * @copyright Copyright (c) 2017, Robin Appelman <[email protected]> | ||
| * |
There was a problem hiding this comment.
Missing @license GNU AGPL version 3 or any later version
| <?php | ||
| /** | ||
| * @copyright Copyright (c) 2017, Robin Appelman <[email protected]> | ||
| * |
There was a problem hiding this comment.
Missing @license GNU AGPL version 3 or any later version
| * @since 12.0.0 | ||
| */ | ||
| public function getRemote(); | ||
| } |
| <?php | ||
| /** | ||
| * @copyright Copyright (c) 2017, Robin Appelman <[email protected]> | ||
| * |
There was a problem hiding this comment.
Missing @license GNU AGPL version 3 or any later version
| <?php | ||
| /** | ||
| * @copyright Copyright (c) 2017, Robin Appelman <[email protected]> | ||
| * |
There was a problem hiding this comment.
Missing @license GNU AGPL version 3 or any later version
| * @since 12.0.0 | ||
| */ | ||
| public function isValidCloudId($cloudId); | ||
| } |
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
|
@nickvergessen all fixed |
Codecov Report@@ Coverage Diff @@
## master #3297 +/- ##
============================================
- Coverage 54.21% 54.17% -0.04%
- Complexity 20987 21042 +55
============================================
Files 1304 1306 +2
Lines 80105 80336 +231
Branches 1253 1253
============================================
+ Hits 43426 43526 +100
- Misses 36679 36810 +131
Continue to review full report at Codecov.
|
nickvergessen
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having at least 3 different implementations that might not all behave in the same way.
Additionally, having a single api point makes it easier to add more "fancy" ways to resolve the cloud id such as the various ways described in #782