-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checkboxes on login #3257
Fix checkboxes on login #3257
Conversation
7f3633b
to
e3bb3c9
Compare
Looks good! Only one thing: Is the checkmark black or transparent? Previously that part was transparent, and it will look nicer (also with themes) cause the background color shines through. |
It's black. It was easier to do. |
Please merge #3341 before continuing this pr! :) |
@skjnldsv can we merge this first, because it fixes an important bug? The other thing is polishing. |
I would prefer to merge the transparent checkbox and then I will update this pr accordingly :) |
@skjnldsv can you update this? :) Also, on the login page it’s a bit strange: The »Stay logged in« text is white and on hover slightly transparent. The checkbox however is slightly transparent and then on hover white. The other way around. Can you adjust it so it fits the text? |
e3bb3c9
to
00c7ca2
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
00c7ca2
to
4dec5a7
Compare
@jancborchardt Updated. |
@nextcloud/designers Please review! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
I removed all lines about radio (since it's not used in the installation page nor login) and removed everything concerning the default checkbox (not white) since it's not used either.
Before / After

