Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkboxes on login #3257

Merged
merged 1 commit into from
Feb 20, 2017
Merged

Fix checkboxes on login #3257

merged 1 commit into from
Feb 20, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 25, 2017

I removed all lines about radio (since it's not used in the installation page nor login) and removed everything concerning the default checkbox (not white) since it's not used either.

Before / After
capture d ecran_2017-01-25_13-34-25
capture d ecran_2017-01-25_13-34-01

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Jan 25, 2017
@skjnldsv skjnldsv added this to the Nextcloud 12.0 milestone Jan 25, 2017
@skjnldsv skjnldsv self-assigned this Jan 25, 2017
@skjnldsv skjnldsv force-pushed the updated-guest-checkboxes branch from 7f3633b to e3bb3c9 Compare January 25, 2017 12:39
@jancborchardt
Copy link
Member

jancborchardt commented Jan 25, 2017

Looks good! Only one thing: Is the checkmark black or transparent? Previously that part was transparent, and it will look nicer (also with themes) cause the background color shines through.

@skjnldsv
Copy link
Member Author

It's black. It was easier to do.
The other possibility is to but a white background on the svg and a transparent checkbox and set an overflow hidden on the checkbox. Like to we will have a transparent checkbox, but we won't be able to use css to change the colour (in case of someone wants to customise its checkbox) 😃

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 12, 2017
@skjnldsv
Copy link
Member Author

Please merge #3341 before continuing this pr! :)

@jancborchardt
Copy link
Member

@skjnldsv can we merge this first, because it fixes an important bug? The other thing is polishing.

@skjnldsv
Copy link
Member Author

I would prefer to merge the transparent checkbox and then I will update this pr accordingly :)

@jancborchardt
Copy link
Member

@skjnldsv can you update this? :)

Also, on the login page it’s a bit strange: The »Stay logged in« text is white and on hover slightly transparent. The checkbox however is slightly transparent and then on hover white. The other way around. Can you adjust it so it fits the text?

@skjnldsv skjnldsv force-pushed the updated-guest-checkboxes branch from e3bb3c9 to 00c7ca2 Compare February 15, 2017 16:04
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the updated-guest-checkboxes branch from 00c7ca2 to 4dec5a7 Compare February 15, 2017 16:16
@skjnldsv
Copy link
Member Author

@jancborchardt Updated.
I did a quick cleanup of the quotes too.

@skjnldsv
Copy link
Member Author

kazam_screencast_00000

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 15, 2017
@skjnldsv
Copy link
Member Author

@nextcloud/designers Please review! 🚀

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@LukasReschke LukasReschke merged commit 24fc7dc into master Feb 20, 2017
@LukasReschke LukasReschke deleted the updated-guest-checkboxes branch February 20, 2017 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants