Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file creation from template without ext #28871

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fix file creation from template without ext #28871

merged 1 commit into from
Sep 17, 2021

Conversation

skjnldsv
Copy link
Member

Reproducing:

  1. Create a new text file
  2. Enter a name without the .md extension
  3. Select any template
  4. See error

@skjnldsv skjnldsv requested a review from a team September 17, 2021 08:09
@skjnldsv skjnldsv self-assigned this Sep 17, 2021
@skjnldsv skjnldsv requested review from artonge, julien-nc and Pytal and removed request for a team September 17, 2021 08:09
@skjnldsv skjnldsv added this to the Nextcloud 23 milestone Sep 17, 2021
@skjnldsv
Copy link
Member Author

/backport to stable22

@skjnldsv
Copy link
Member Author

/backport to stable21

@skjnldsv skjnldsv requested a review from a team September 17, 2021 08:10
PVince81
PVince81 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine 👍

@skjnldsv skjnldsv mentioned this pull request Sep 17, 2021
Closed
@skjnldsv skjnldsv linked an issue Sep 17, 2021 that may be closed by this pull request
Alert “Unable to create new file from template” #26672
Closed
@skjnldsv skjnldsv removed a link to an issue Sep 17, 2021
Alert “Unable to create new file from template” #26672
Closed
@Pytal
Copy link
Member

Pytal commented Sep 17, 2021

⚙failures unrelated

@Pytal Pytal merged commit a102333 into master Sep 17, 2021
@Pytal Pytal deleted the fix/template-create-without-extension branch September 17, 2021 20:19
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 17, 2021
@szaimen
Copy link
Contributor

szaimen commented Sep 17, 2021

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 17, 2021
Merged
@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 17, 2021
Merged
@szaimen
Copy link
Contributor

szaimen commented Sep 17, 2021

Were templates introduced with NC21?

@PVince81
Copy link
Member

Were templates introduced with NC21?

indeed, let's skip the NC 20 backport then

@szaimen szaimen mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@Pytal Pytal Pytal approved these changes

@artonge artonge Awaiting requested review from artonge

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: templates
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @Pytal @szaimen @PVince81