Only recommand for php-sodium on >= PHP 7.4 #28332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because php-sodium will solve the missing PASSWORD_ARGON2I constant problem only on >= php 7.4, previously argon2 wasn't part of the standard extension and was disabled on Centos/RHEL. So installing php-sodium on php 7.2 for example wouldn't hide the message. Tested on Fedora with php 7.4, Centos 7 with php 7.2, Centos 8 with php 7.2 and openSUSE with php 7.4. Signed-off-by: Carl Schwan <[email protected]>
|
/backport to stable20 |
|
/backport to stable21 |
|
/backport to stable22 |
|
Fun @Conan-Kudo just told me that contrary to that 1 says, not even epel will provide php-sodium with PHP 7.4 :( It's a bit annoying and I added a comment to https://bugzilla.redhat.com/show_bug.cgi?id=1990844 |
kesselb
approved these changes
Aug 6, 2021
|
Is the same true for PASSWORD_ARGON2ID or may it be available as successor when PASSWORD_ARGON2I is not? Generally, before giving Argon2 too much weight, remember the discussion with its RFC author where it turned out to be less secure than bcrypt in the <1 seconds hashing time we usually want here. So an alternative would be to revert to bcrypt as default and drop all Argon2 related checks and warnings. |
ChristophWurst
approved these changes
Aug 31, 2021
This was referenced Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.
So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.
Link for more info: https://lists.fedoraproject.org/archives/list/[email protected]/message/DPUS5BTCJD6IXREHJKMRK7JEFNSHKFSR/
Signed-off-by: Carl Schwan [email protected]