Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the dav propfind plugins always use the proper user id #28084

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

juliusknorr
Copy link
Member

For old android versions it could happen that the requests are performed
with a login name instead of the actual user id, so before this change
the property methods used the wrong value for fetching their information

Found in nextcloud/circles#672

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jul 21, 2021
@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Jul 21, 2021
@juliusknorr
Copy link
Member Author

/backport to stable22

@ArtificialOwl
Copy link
Member

ArtificialOwl commented Jul 21, 2021

in case anyone wondering, this should fix also an unknown bug of shared files not being displayed in the android app when using LDAP

@juliusknorr juliusknorr force-pushed the bugfix/noid/dav-user-id branch from cb3d1ac to 650d297 Compare July 21, 2021 13:09
@Pytal
Copy link
Member

Pytal commented Jul 21, 2021

CI 🤔

Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it fixes the original issue

For old android versions it could happen that the requests are performed
with a login name instead of the actual user id, so before this change
the property methods used the wrong value for fetching their information

Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr force-pushed the bugfix/noid/dav-user-id branch from 650d297 to 6909ce6 Compare July 22, 2021 10:28
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 22, 2021
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow! 🙈

@szaimen
Copy link
Contributor

szaimen commented Jul 22, 2021

Not sure if the failing tests are unrelated...

@skjnldsv
Copy link
Member

Doesn't seems related no

@skjnldsv skjnldsv merged commit 9797674 into master Jul 23, 2021
@skjnldsv skjnldsv deleted the bugfix/noid/dav-user-id branch July 23, 2021 06:31
@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor

szaimen commented Jul 24, 2021

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants