-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that the dav propfind plugins always use the proper user id #28084
Conversation
/backport to stable22 |
in case anyone wondering, this should fix also an unknown bug of shared files not being displayed in the android app when using LDAP |
cb3d1ac
to
650d297
Compare
CI 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it fixes the original issue
For old android versions it could happen that the requests are performed with a login name instead of the actual user id, so before this change the property methods used the wrong value for fetching their information Signed-off-by: Julius Härtl <[email protected]>
650d297
to
6909ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow! 🙈
Not sure if the failing tests are unrelated... |
Doesn't seems related no |
The backport to stable22 failed. Please do this backport manually. |
/backport to stable22 |
For old android versions it could happen that the requests are performed
with a login name instead of the actual user id, so before this change
the property methods used the wrong value for fetching their information
Found in nextcloud/circles#672