Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nikic/php-parser from 4.10.4 to 4.10.5 #27443

Closed

Conversation

ChristophWurst
Copy link
Member

Ref nextcloud/3rdparty#662

This isn't used much except for CI -> green CI means we merge this.

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Jun 9, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 22 milestone Jun 9, 2021
@ChristophWurst ChristophWurst self-assigned this Jun 9, 2021
@MichaIng
Copy link
Member

MichaIng commented Jun 9, 2021

green CI means we merge this.

Drone acceptance files sharing test fails at:

    And I create a new folder named "Subfolder" # FileListContext::iCreateANewFolderNamed()
      │ Create New folder menu item in file list could not be clicked
      │ Exception message: element not interactable
      │   (Session info: chrome=90.0.4430.85)
      │   (Driver info: chromedriver=90.0.4430.24 (4c6d850f087da467d926e8eddb76550aed655991-refs/branch-heads/4430@{#429}),platform=Linux 4.15.0-124-generic x86_64)
      │ Trying again
      │ 
      element not interactable
        (Session info: chrome=90.0.4430.85)
        (Driver info: chromedriver=90.0.4430.24 (4c6d850f087da467d926e8eddb76550aed655991-refs/branch-heads/4430@{#429}),platform=Linux 4.15.0-124-generic x86_64) (WebDriver\Exception\ElementNotVisible)

@ChristophWurst
Copy link
Member Author

I've seen one failing acceptance test all day long 🤷

@ChristophWurst
Copy link
Member Author

Restarted. Let's see ⌛

@blizzz
Copy link
Member

blizzz commented Jun 9, 2021

Was it Scenario: resharee sees a folder created by the owner in a shared folder # /drone/src/tests/acceptance/features/app-files-sharing.feature:197 before? That was not the only failing one.

@blizzz
Copy link
Member

blizzz commented Jun 9, 2021

another restart fwiw

@ChristophWurst ChristophWurst force-pushed the dependabot/composer/nikic/php-parser-4.10.5 branch from ddc570e to 6cf174f Compare June 10, 2021 05:54
@ChristophWurst ChristophWurst deleted the dependabot/composer/nikic/php-parser-4.10.5 branch June 10, 2021 05:54
@ChristophWurst
Copy link
Member Author

done via #27449 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants