Run s3 tests again #27198
Merged
Run s3 tests again #27198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
May 28, 2021
•
juliusknorr
commented
- reenable s3/azure tests
- check for alternatives to fake-s3 as it does not support multipart uploads -> using minio now
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
tests/run-s3-tests
branch
from
c941251 to
85e5580
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
tests/run-s3-tests
branch
from
8ba917a to
55cabef
Compare
juliusknorr
commented
Jul 1, 2021
| @@ -2117,13 +2117,23 @@ kind: pipeline | |||
| name: object-store-s3 | |||
|
|
|||
| steps: | |||
| - name: minio | |||
| image: ghcr.io/nextcloud/continuous-integration-minio:latest | |||
| detach: true | |||
There was a problem hiding this comment.
Needed to move this to a detached step to properly pass the commands starting the server
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
skjnldsv
approved these changes
Jul 1, 2021
This was referenced Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.