Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Federated Learning of Cohorts (FLoC) #27192

Closed
wants to merge 1 commit into from
Closed

Block Federated Learning of Cohorts (FLoC) #27192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .htaccess
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
Header onsuccess unset X-XSS-Protection
Header always set X-XSS-Protection "1; mode=block"

Header onsuccess unset Permissions-Policy
Header always set Permissions-Policy "interest-cohort=()"
Copy link
Member

@MichaIng MichaIng Jun 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this header is set script-wise already. Currently the deprecated Feature-Policy but that is about to be changed: #23825

So this causes issues with doubled headers, or it is script-internally overridden. So this instead needs to be applied script-wise, similar to CSP. What instead would make sense, is to unset both, Permissions-Policy and CSP "onsuccess" and "always", so that it is assured that those are set only by Nextcloud (script-internally). The modHeadersAvailable variable only controls X-* headers and Referrer-Policy, so those can be set webserver-side.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, and there is an ongoing discussion about the interest of setting this up or not. Let's close the debate first before setting this up. #26539


SetEnv modHeadersAvailable true
</IfModule>

Expand Down