avoid empty null default with value that will be inserted anyways #24315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
requested review from
rullzer,
MorrisJobke,
ChristophWurst and
juliusknorr
|
/backport to stable20 |
|
/backport to stable19 |
|
/backport to stable18 |
This comment has been minimized.
This comment has been minimized.
ChristophWurst
approved these changes
Nov 24, 2020
ChristophWurst
added
4. to release
|
/backport to stable20 |
|
/backport to stable19 |
|
/backport to stable18 |
|
The backport to stable20 failed. Please do this backport manually. |
This was referenced Nov 24, 2020
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23174
replaces #24208