[encryption] Remove dependency fetching inside the constructor and mo… #24289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
added
3. to review
MorrisJobke
requested review from
rullzer,
LukasReschke,
ChristophWurst,
juliusknorr and
skjnldsv
…ve them to method call parameters Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
techdebt/noid/encryption-make-application-class-dependency-free
branch
from
3180eb4 to
efe6441
Compare
1 task
skjnldsv
approved these changes
Nov 23, 2020
MorrisJobke
deleted the
techdebt/noid/encryption-make-application-class-dependency-free
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ve them to method call parameters
Once #24267 is in this will result in an empty constructor 🚀 And this then might make #24036 easier to accomplish.