Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circleId too short in some request #24098

Merged
merged 1 commit into from
Nov 17, 2020
Merged

circleId too short in some request #24098

merged 1 commit into from
Nov 17, 2020

Conversation

ArtificialOwl
Copy link
Member

Sometimes, the getShareWith() will only contains the CircleUniqueId and not a complex string. In that case, the CircleId should not be cropped that much.

@ArtificialOwl
Copy link
Member Author

/backport to stable19

@faily-bot
Copy link

faily-bot bot commented Nov 13, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35484: failure

mariadb10.1-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

ChristophWurst
ChristophWurst approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@ArtificialOwl ArtificialOwl mentioned this pull request Nov 16, 2020
Merged
@rullzer rullzer added this to the Nextcloud 21 milestone Nov 17, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Nov 17, 2020
juliusknorr
juliusknorr approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@nickvergessen
Copy link
Member

/backport to stable20

@rullzer rullzer merged commit 2429e8b into master Nov 17, 2020
@rullzer rullzer deleted the bugfix/noid/resharing-rights-on-circles branch November 17, 2020 10:22
This was referenced Nov 17, 2020
Merged
Merged
@ChristophWurst
Copy link
Member

/backport to stable19

@ChristophWurst
Copy link
Member

/backport to stable20

This was referenced Nov 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
5 participants
@ArtificialOwl @nickvergessen @ChristophWurst @juliusknorr @rullzer