Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes potential passing of null to getUserGroupIds #23508

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Oct 16, 2020

fixes #23355

the issue was introduced with 756fe45. The method of the group manager previously used was able to deal with a passed null, but getUserGroupIds asks for IUser specifically.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@MorrisJobke
Copy link
Member

/backport to stable20

@juliusknorr juliusknorr added the 4. to release Ready to be released and/or waiting for tests to finish label Oct 16, 2020
@MorrisJobke MorrisJobke merged commit 09501e1 into master Oct 16, 2020
@MorrisJobke MorrisJobke deleted the fix/23355/iuser-expected-null-given branch October 16, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NC20.0.0.9 breaks sync to android-app
3 participants