Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] add mount point to quota warning message #23169

Closed
wants to merge 1 commit into from
Closed

[stable18] add mount point to quota warning message #23169

wants to merge 1 commit into from

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 4, 2020 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22913

@icewind1991 @backportbot
add mount point to quota warning message
e2e517f 
makes it more clear to the user what the quota applies to

Signed-off-by: Robin Appelman <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.10 milestone Oct 4, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33641: failure

sqlite

Show full log 
There were 2 errors:

1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:303

2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:338

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mariadb10.1-php7.2

Show full log 
There were 2 errors:

1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:303

2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:338

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mariadb10.4-php7.3

Show full log 
There were 2 errors:

1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:303

2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:338

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql5.6-php7.2

Show full log 
There were 2 errors:

1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:303

2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:338

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\TagsTest::testAddTags
add() returned an ID <= 0
Failed asserting that 0 is greater than 0.

/drone/src/tests/lib/TagsTest.php:101

postgres9-php7.3

Show full log 
There were 2 errors:

1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:303

2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:338

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

postgres11-php7.2

Show full log 
There were 2 errors:

1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:303

2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3

/drone/src/lib/private/legacy/helper.php:547
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:333
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:338

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log 
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:338
Show full log 
  Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
    Given I act as John                                                                   # ActorContext::iActAs()
    And I am logged in as the admin                                                       # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I am logged in                                                                    # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I am logged in as "user1"                                                         # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                                     # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                       # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user1"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as John                                                                     # ActorContext::iActAs()
    And I set the share with "user0" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    And I see that "user0" can not create in the share                                    # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                                    # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I open the details view for "Shared folder"                                       # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                               # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                      # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded             # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I set the share with "user1" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    Then I see that "user1" can not create in the share                                   # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I see that "user1" can not be allowed to create in the share                      # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I see that it is not possible to create new files                                 # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
      Failed asserting that true is false.

@rullzer rullzer added the 3. to review Waiting for reviews label Oct 5, 2020
@MorrisJobke
Copy link
Member

When fixing the conflicts please also add #23193

@rullzer rullzer mentioned this pull request Oct 6, 2020
Merged
2 tasks
@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
2 tasks
@rullzer
Copy link
Member

rullzer commented Nov 12, 2020

@icewind1991 can you also check this one?

@MorrisJobke
Copy link
Member

Let's backport the fixed stable19 PR: #23168

@MorrisJobke MorrisJobke deleted the backport/22913/stable18 branch November 12, 2020 19:01
@MorrisJobke
Copy link
Member

#24078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 18.0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @rullzer @skjnldsv @icewind1991