-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change color of displayname and ellipsis status message #22317
Conversation
ff42360
to
393a34e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a title
attribute on the ellipsised text to show the full status on hover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a title
attribute on the ellipsised text to show the full status on hover?
Nevermind, fixed here. |
393a34e
to
5ad9cba
Compare
I wouldn’t do that, we shouldn’t have tooltips all over (e.g. we also removed them from the avatars in Mail as it made no sense). When one wants to check the full message, they can go to the "Set custom status" dialog – and it’s their status in the first place. :) @georgehrke otherwise it looks good! |
let me rebase |
Signed-off-by: Georg Ehrke <[email protected]>
5ad9cba
to
d7a1c01
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32170: failuremariadb10.1-php7.2Show full log
mariadb10.4-php7.3Show full log
mysql8.0-php7.2
acceptance-header
Show full log
|
Failures unrelated, merging. |
Signed-off-by: Georg Ehrke [email protected]