-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Recent status changes" Dashboard #22284
Conversation
georgehrke
commented
Aug 18, 2020
•
edited
Loading
edited
Empty content | Statuses |
---|---|
![]() |
![]() |
c223bb9
to
f8d036f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! :) Design feedback:
- The icon should be black, we changed that for Files as well
- The title is a bit long, let’s cut it to "Recent statuses"?
- Should we add time info to the subline with a comma? Like "🌴 Vacationing, 3 days ago"
Edited by @georgehrke: Turned into checkboxes
3adb887
to
d468b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
@juliushaertl @eneiluj Would you consider the misaligned empty content message an issue in nc/vue-dashboard? |
fcfbbc1
to
0a34555
Compare
Rebased and squashed |
1d9a25d
to
af7ab2d
Compare
Rebased, squashed and fixed @jancborchardt's remark about the dot. |
Needs a rebase. But then good to go I think |
Signed-off-by: Georg Ehrke <[email protected]>
af7ab2d
to
bd6a6cf
Compare
Rebased again |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32092: failureacceptance-app-files
Show full log
acceptance-app-files-sharing
Show full log
|
@georgehrke @eneiluj not sure if this encoding issue is something for this widget specifically, for user_status or for the Dashboard widget component: |