Add 'Reasons to use Nextcloud in your organization' call to action in settings

[jancborchardt]

As discussed @karlitschek

Need a developer to take over or offer advice on:

• Actually making the document open in the viewer / files_pdfviewer on click of the button, cc @juliushaertl @skjnldsv
• Decide if the "skeleton" folder is the right place to put this – it’s the only folder with documents so I figured it’s as good as any, and will also make that file show up in a fresh dev instance which isn’t bad either.

(The file is not the final version yet as Marija and I are still polishing it up.)

[karlitschek]

great! 👍

[jospoortvliet]

Should the icon not be white, too? This grey looks a bit off...

[jancborchardt]

@jancborchardt yep it should, will adjust as soon as we have the final document :)

[skjnldsv]

• Actually making the document open in the viewer / files_pdfviewer on click of the button, cc @juliushaertl @skjnldsv

files_pdfviewer is still not using viewer, so no idea what their api is

[juliusknorr]

files_pdfviewer is still not using viewer, so no idea what their api is

There is none most likely. Also using this will only work if the file is in the example files and not removed by the user. So I'd rather vote to use something like https://www.npmjs.com/package/vue-pdf and show it in a modal just for personal the settings.

[skjnldsv]

So I'd rather vote to use something like npmjs.com/package/vue-pdf and show it in a modal just for personal the settings.

How hard would it be to move to viewer 🙈 ?

EDIT: let me try to see that today for 20

[jancborchardt]

Added the final pdf document to core/skeleton now, will have to hand this over then – to you @skjnldsv?

[juliusknorr]

Added the final pdf document to core/skeleton now, will have to hand this over then – to you @skjnldsv?

Should be in https://github.com/nextcloud/example-files i think. ;)

Ah my bad, missed nextcloud/example-files#10

[skjnldsv]

Added the final pdf document to core/skeleton now, will have to hand this over then – to you @skjnldsv?

sure commit incoming

[skjnldsv]

A CSP issue, I asked Roeland for help 👍
Otherwise implementation is done with conditional rendering of the file is not in the user folder anymore!

[rullzer]

nextcloud/files_pdfviewer#201
The fix :)

[rullzer]

Will it actually be in your home folder?

[skjnldsv]

According to skeleton, yes, no?

[rullzer]

@jancborchardt @karlitschek we allow admins to set custom skeleton files. In that case we have no way to link to the file. How would be open it then?

[karlitschek]

@rullzer Agreed. I think the file needs to live somewhere else. Not in the skeleton

[jancborchardt]

@jancborchardt @karlitschek we allow admins to set custom skeleton files. In that case we have no way to link to the file. How would be open it then?

Yes, as said I have no idea where to put it – I think it’s good to have it in example files and skeleton just to show it to devs and users. But yes, for it to properly work it also needs to live somewhere permanently → and that’s your call @rullzer.

[rullzer]

So actually putting the file somewhere we can. But the issue is a bit that I think the viewer is only build to handle opening from webdav. Which we can't if it is nto in your main files...

[skjnldsv]

But the issue is a bit that I think the viewer is only build to handle opening from webdav. Which we can't if it is nto in your main files...

Yep, only if it's within DAV

[rullzer]

Ok so that is a bit problematic then.

@jancborchardt else we just serve the file from a controller and people open it int he pdf app of their chosing... I think almost everybody can properly open pdfs.

[rullzer]

still conflicts :S

[rullzer]

/compile amend /

[skjnldsv]

Rebased ready to go

[skjnldsv]

So many failures

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32717: failure

mysql5.6-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopy with data set #1 ('/source.txt', '/target with space.txt')
Expected /target with space.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that false matches expected 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'.

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:235

[ChristophWurst]

🙄

[ChristophWurst]

lots of packages were updated unintentionally 🐘

[skjnldsv]

Sometimes done automatically :p
If it's deps of deps

[ChristophWurst]

Nope. Only if you npm update or npm i another dependency. But this doesn't happen just so.

[rullzer]

@skjnldsv ?

[skjnldsv]

No clue!
It's merged now 🤷

[rullzer]

Then let's Yolo on! 🎉

[MorrisJobke]

@rullzer Psalm said no: #22650 😉

[jospoortvliet]

@jancborchardt yep it should, will adjust as soon as we have the final document :)

So sadly this made it into the release 🙈

#24450