Allow crash reporters registration during app bootstrap #21457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
enhancement
3. to review
ChristophWurst
requested review from
rullzer,
nickvergessen,
MorrisJobke,
blizzz,
juliusknorr,
kesselb and
gary-kim
I don't know what this means. But I'm on board! |
It's a very lazy but also very fast koala |
rullzer
reviewed
Jun 17, 2020
rullzer
approved these changes
Jun 17, 2020
2 tasks
juliusknorr
approved these changes
Jun 17, 2020
|
php-cs is failing |
ChristophWurst
force-pushed
the
enhancement/crash-reporters-registration-boostrap
branch
from
e0efd07 to
8fba7a2
Compare
11 tasks
|
CI says no |
|
Christoph says yes |
ChristophWurst
force-pushed
the
enhancement/crash-reporters-registration-boostrap
branch
from
8fba7a2 to
bde8ee7
Compare
ChristophWurst
added
4. to release
🐨 🚀 |
|
CI still says no... 🐨 💣 |
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/crash-reporters-registration-boostrap
branch
from
bde8ee7 to
2b7b714
Compare
|
Christoph says yes, again. Turns out I did not check the registry tests and I even found an uncovered edge case while writing the tests 🐨 🚀 |
|
🐨 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
This changes the crash reporters registration from
… when we might not even use it.
After
It now just appends a string to an array. The service is only built if we really need it. Thus 🐨:rocket:
\OCP\Support\CrashReport\IRegistryis obsolete, so I've deprecated it.For ChristophWurst/nextcloud_sentry#207, but needs #21456 to work properly.