Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to wrong class name #21146

Merged
merged 1 commit into from
May 29, 2020
Merged

Conversation

danxuliu
Copy link
Member

Follow up to #20726

\OCP\IShare does not exist; the right name is \OCP\Share\IShare, although it is already imported as IShare.

\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu danxuliu added this to the Nextcloud 20 milestone May 28, 2020
@danxuliu danxuliu requested review from rullzer and MorrisJobke May 28, 2020 23:48
@danxuliu
Copy link
Member Author

/backport to stable19

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 29, 2020
@rullzer rullzer merged commit ca606ce into master May 29, 2020
@rullzer rullzer deleted the fix-reference-to-wrong-class-name branch May 29, 2020 06:46
@MorrisJobke
Copy link
Member

Why not backport down to 17 because the linked PR was also backported down to 17?

@danxuliu
Copy link
Member Author

Why not backport down to 17 because the linked PR was also backported down to 17?

Because the backports to 17 and 18 were only partial backports and they do not include the change that is fixed here :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants