Fix public layout header title & description #20744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
added
bug
design
skjnldsv
requested review from
rullzer,
nickvergessen,
MorrisJobke,
jancborchardt and
ChristophWurst
This was referenced Apr 30, 2020
|
Not sure, but I'll look at the backport |
|
/backport to stable17 |
|
Tested with public calendars 👍
|
georgehrke
approved these changes
Apr 30, 2020
ChristophWurst
approved these changes
Apr 30, 2020
MorrisJobke
added
4. to release
|
Failures unrelated |
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Broke by other stuff and #19913
Closes #19541
Fix #19479
We should have some minimal css for this, to not rely on the header.scss file.
This is supposed to be a minimal public template and we load 140kb of css ^^'