Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to EMailTemplate interface in constructor call. #20650

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Adhere to EMailTemplate interface in constructor call. #20650

merged 1 commit into from
Apr 27, 2020

Conversation

tekhnee
Copy link
Member

@tekhnee tekhnee commented Apr 25, 2020

Email creation appears to have been refactored lately but it looks like custom template-based emails were left out. See #20648.

Signed-off-by: Tekhnee [email protected]

Email creation appears to have been refactored lately but it looks like custom template-based emails were left out.

Signed-off-by: Tekhnee <[email protected]>
@kesselb kesselb added 3. to review Waiting for reviews bug labels Apr 25, 2020
@kesselb kesselb added this to the Nextcloud 19 milestone Apr 25, 2020
@nickvergessen nickvergessen mentioned this pull request Apr 25, 2020
11 tasks
@MorrisJobke MorrisJobke merged commit 2d7f71f into nextcloud:master Apr 27, 2020
@welcome
Copy link

welcome bot commented Apr 27, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@MorrisJobke
Copy link
Member

/backport to stable18

@MorrisJobke
Copy link
Member

Caused by #20246 (cc @rullzer) thus backporting.

@MorrisJobke
Copy link
Member

/backport to stable17

@backportbot-nextcloud
Copy link

backport to stable18 in #20682

@backportbot-nextcloud
Copy link

backport to stable17 in #20683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants