Use a proper upload file so propfinds return 404 #20570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
georgehrke,
icewind1991,
schiessle,
kesselb and
tobiasKaminsky
|
Nice 👍 That works because sabreNode is not a instance of Node anymore 👏 |
Fixes #20235 By using an UploadFile we make sure that we don't need to have another check everywhere for the path. But we just have ot check (which we have to anyway) if it is a proper Connector/File (or directory). Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
fix/20235/use_uploadfile
branch
from
d0e130c to
8730cc6
Compare
This comment has been minimized.
This comment has been minimized.
|
@kesselb feel free to directly push to the branch :) |
Signed-off-by: Daniel Kesselberg <[email protected]>
|
Can we have a backport of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20235, Closes #20569
By using an UploadFile we make sure that we don't need to have another
check everywhere for the path. But we just have ot check (which we have
to anyway) if it is a proper Connector/File (or directory).
Signed-off-by: Roeland Jago Douma [email protected]