Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Allow to await the sidebar #19089

Merged
merged 2 commits into from
Feb 5, 2020
Merged

[stable18] Allow to await the sidebar #19089

merged 2 commits into from
Feb 5, 2020

Conversation

skjnldsv
Copy link
Member

bacport of #18929

@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews feature: file sidebar Related to the file sidebar component labels Jan 23, 2020
@skjnldsv skjnldsv added this to the Nextcloud 18.0.1 milestone Jan 23, 2020
@skjnldsv skjnldsv self-assigned this Jan 23, 2020
@skjnldsv
Copy link
Member Author

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/18929/enh/sidebar/promise branch from 32dac54 to db7a0a9 Compare January 23, 2020 07:49
@skjnldsv
Copy link
Member Author

Bump

@rullzer rullzer mentioned this pull request Feb 3, 2020
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 4, 2020

So, yes, no? :p

@ChristophWurst
Copy link
Member

#18929 (comment) 🤷‍♂️

@juliusknorr
Copy link
Member

juliusknorr commented Feb 4, 2020 •
edited
Loading

I'd say it is not a breaking api change since it basically adds returning a promise, so any previous implementation will continue to work.

@skjnldsv @rullzer
Allow to await the sidebar
f4d298c 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@rullzer rullzer force-pushed the backport/18929/enh/sidebar/promise branch from db7a0a9 to df00000 Compare February 5, 2020 19:09
@rullzer
Copy link
Member

rullzer commented Feb 5, 2020

/compile amend /

@skjnldsv @npmbuildbot
Close handling
b074be1 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/18929/enh/sidebar/promise branch from df00000 to b074be1 Compare February 5, 2020 19:12
@rullzer rullzer merged commit 9fd0153 into stable18 Feb 5, 2020
@rullzer rullzer deleted the backport/18929/enh/sidebar/promise branch February 5, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement feature: file sidebar Related to the file sidebar component
Projects
None yet
Milestone
Nextcloud 18.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @ChristophWurst @juliusknorr @rullzer