Clean all superposed white backgrounds #1657
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,9 +29,9 @@ input[type="button"], | |
| margin: 3px 3px 3px 0; | ||
| padding: 7px 6px 5px; | ||
| font-size: 13px; | ||
| background: transparent; | ||
| color: rgba(0, 0, 0, .8); | ||
| border: 1px solid rgba(0, 0, 0, .133); | ||
| outline: none; | ||
| border-radius: 3px; | ||
| } | ||
|
|
@@ -48,8 +48,8 @@ input[type="tel"], | |
| input[type="url"], | ||
| input[type="time"], | ||
| textarea { | ||
| background: transparent; | ||
| color: rgba(0, 0, 0, .666); | ||
| cursor: text; | ||
| font-family: inherit; /* use default ownCloud font instead of default textarea monospace */ | ||
| } | ||
|
|
@@ -74,7 +74,7 @@ input[type="tel"]:hover, input[type="tel"]:focus, input[type="tel"]:active, | |
| input[type="url"]:hover, input[type="url"]:focus, input[type="url"]:active, | ||
| input[type="time"]:hover, input[type="time"]:focus, input[type="time"]:active, | ||
| textarea:hover, textarea:focus, textarea:active { | ||
| color: rgba(0, 0, 0, .8); | ||
| -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=100)"; | ||
| opacity: 1; | ||
| } | ||
|
|
@@ -149,7 +149,7 @@ input[type="checkbox"].checkbox--white:indeterminate:disabled + label:before { | |
| } | ||
|
|
||
| input[type="checkbox"].checkbox:hover+label:before, input[type="checkbox"]:focus+label:before { | ||
| color:rgba(0, 0, 0, .933) !important; | ||
| } | ||
|
|
||
| input[type="radio"].radio { | ||
|
|
@@ -210,19 +210,19 @@ select { | |
| -webkit-appearance: none; | ||
| -moz-appearance: none; | ||
| appearance: none; | ||
| background: url('../../core/img/actions/triangle-s.svg') no-repeat right 8px center rgba(0, 0, 0, .054); | ||
| outline: 0; | ||
| padding-right: 24px !important; | ||
| } | ||
|
|
||
| select:hover { | ||
| background-color: rgba(0, 0, 0, .003); | ||
| } | ||
|
|
||
| .select2-choices { | ||
| border: 1px solid #ddd; | ||
| border-radius: 3px; | ||
| color: rgba(0, 0, 0, .8); | ||
| background-image: none; | ||
| } | ||
| .select2-dropdown-open .select2-choices { | ||
|
|
@@ -237,7 +237,7 @@ input img, button img, .button img { | |
| } | ||
|
|
||
| input[type="submit"].enabled { | ||
| background-color: rgba(0,243,0,0.6); | ||
| border: 1px solid #5e5; | ||
| } | ||
|
|
||
|
|
@@ -257,10 +257,10 @@ button, .button, | |
| width: auto; | ||
| min-width: 25px; | ||
| padding: 5px; | ||
| background-color: rgba(0, 0, 0, .054); | ||
| font-weight: 600; | ||
| color: rgba(0, 0, 0, .666); | ||
| border: 1px solid rgba(0, 0, 0, .054); | ||
| cursor: pointer; | ||
| } | ||
| select, .button.multiselect { | ||
|
|
@@ -272,8 +272,8 @@ button:hover, button:focus, | |
| .button:hover, .button:focus, | ||
| .button a:focus, | ||
| select:hover, select:focus, select:active { | ||
| background-color: rgba(0, 0, 0, .1); | ||
|
There was a problem hiding this comment. @jancborchardt same here. This is not visible to the eye. I changed to something more visible. What do you think? There was a problem hiding this comment. The point about this was that the background color shines a bit through. For example when we have it in the header of the link share page there are buttons on the top right. |
||
| color: rgba(0, 0, 0, .933); | ||
| } | ||
| input[type="submit"] img, input[type="button"] img, button img, .button img { cursor:pointer; } | ||
| #header .button { | ||
|
|
@@ -288,11 +288,11 @@ button:disabled, button:disabled:hover, button:disabled:focus, | |
| a.disabled, a.disabled:hover, a.disabled:focus, | ||
| textarea:disabled { | ||
| background-color: rgba(230,230,230,.9); | ||
| color: rgba(0, 0, 0, .4); | ||
| cursor: default; | ||
| } | ||
| input:disabled+label, input:disabled:hover+label, input:disabled:focus+label { | ||
| color: rgba(0, 0, 0, .4) !important; | ||
| cursor: default; | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jancborchardt I'm not really sure this is humanly visible 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not really. Do you want to adjust this to the equivalent of #fff instead? Or rather it really needs to be solid #fff because by default the select is grey and it could be on top of dark background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't think of dark backgrounds superposition. Because the rgba I'm changing are planned on a #fff bg. If we want a dark background with the same contrast, we should reverse the values. :)
For this line, I think we could just remove it. Or choose a completely different value to set for all inputs:hover.