Fix opening folders from different file lists #14886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
nickvergessen,
MorrisJobke,
ChristophWurst,
skjnldsv and
danxuliu
skjnldsv
approved these changes
Mar 27, 2019
|
/backport to stable15 |
|
/backport to stable14 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 28, 2019
|
Potential regression: #14962 |
aszlig
added a commit
to aszlig/avonc
that referenced
this pull request
Apr 6, 2019
I haven't dug into the details here, but the upstream commit introduced in nextcloud/server#14886 broke publicly shared links in a way so you can't click on subfolders. The regression is tracked upstream at: nextcloud/server#14962 Signed-off-by: aszlig <[email protected]>
This was referenced Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes navigating to folders from file lists which are not the default one. To achieve proper navigation we need to switch to the default file list before trying to navigate to the actual directory.
Steps to reproduce:
Fixes #13028